Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: net/android/gurl_utils.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/android/gurl_utils.cc
diff --git a/net/android/gurl_utils.cc b/net/android/gurl_utils.cc
index c8cb1e4e9981bc51bee260cfad18e70076f0b72b..8fcfe0d4f7486e1986c2d23e4625ba23606cd03e 100644
--- a/net/android/gurl_utils.cc
+++ b/net/android/gurl_utils.cc
@@ -10,18 +10,16 @@
namespace net {
-jstring GetOrigin(JNIEnv* env, jclass clazz, jstring url) {
+ScopedJavaLocalRef<jstring> GetOrigin(JNIEnv* env, jclass clazz, jstring url) {
GURL host(base::android::ConvertJavaStringToUTF16(env, url));
- return base::android::ConvertUTF8ToJavaString(env,
- host.GetOrigin().spec()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, host.GetOrigin().spec());
}
-jstring GetScheme(JNIEnv* env, jclass clazz, jstring url) {
+ScopedJavaLocalRef<jstring> GetScheme(JNIEnv* env, jclass clazz, jstring url) {
GURL host(base::android::ConvertJavaStringToUTF16(env, url));
- return base::android::ConvertUTF8ToJavaString(env,
- host.scheme()).Release();
+ return base::android::ConvertUTF8ToJavaString(env, host.scheme());
}
bool RegisterGURLUtils(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698