components/variations/android/variations_associated_data_android.cc - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/variations/android/variations_associated_data_android.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some newlines for readability Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/oauth2_token_service_delegate_android.h ('K') | « components/dom_distiller/core/url_utils_android.cc ('k') | content/browser/android/content_video_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/variations/android/variations_associated_data_android.cc

diff --git a/components/variations/android/variations_associated_data_android.cc b/components/variations/android/variations_associated_data_android.cc

index db14d8ff0e8a87de90675ea8c78c7b6d159bffec..7bd2800fe5ed10f028617a18ce615d49823bb153 100644

--- a/components/variations/android/variations_associated_data_android.cc

+++ b/components/variations/android/variations_associated_data_android.cc

@@ -17,15 +17,15 @@ namespace variations {

namespace android {

-jstring GetVariationParamValue(JNIEnv* env,

- jclass clazz,

- jstring jtrial_name,

- jstring jparam_name) {

+ScopedJavaLocalRef<jstring> GetVariationParamValue(JNIEnv* env,

+ jclass clazz,

+ jstring jtrial_name,

+ jstring jparam_name) {

std::string trial_name(ConvertJavaStringToUTF8(env, jtrial_name));

std::string param_name(ConvertJavaStringToUTF8(env, jparam_name));

std::string param_value =

variations::GetVariationParamValue(trial_name, param_name);

- return ConvertUTF8ToJavaString(env, param_value).Release();

+ return ConvertUTF8ToJavaString(env, param_value);

}

bool RegisterVariationsAssociatedData(JNIEnv* env) {