components/cronet/android/test/quic_test_server.cc - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/quic_test_server.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some newlines for readability Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/signin/oauth2_token_service_delegate_android.h ('K') | « components/cronet/android/test/native_test_server.cc ('k') | components/dom_distiller/core/url_utils_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/quic_test_server.cc

diff --git a/components/cronet/android/test/quic_test_server.cc b/components/cronet/android/test/quic_test_server.cc

index 1b2cfac94cd3eb888ee71b1f4683d6b1c93b3fd8..b26a90de7f3f10e6218be0ae447723a05263ab0d 100644

--- a/components/cronet/android/test/quic_test_server.cc

+++ b/components/cronet/android/test/quic_test_server.cc

@@ -77,8 +77,8 @@ void ShutdownQuicTestServer(JNIEnv* env, jclass /*jcaller*/) {

delete g_quic_server_thread;

}

-jstring GetServerHost(JNIEnv* env, jclass /*jcaller*/) {

- return base::android::ConvertUTF8ToJavaString(env, kServerHost).Release();

+ScopedJavaLocalRef<jstring> GetServerHost(JNIEnv* env, jclass /*jcaller*/) {

+ return base::android::ConvertUTF8ToJavaString(env, kServerHost);

}

int GetServerPort(JNIEnv* env, jclass /*jcaller*/) {