Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: components/cronet/android/cronet_library_loader.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_library_loader.cc
diff --git a/components/cronet/android/cronet_library_loader.cc b/components/cronet/android/cronet_library_loader.cc
index ddc5f1ba4c958d220f3677ae8befafd7d0b508b4..8e38125344a4bab324b404b7f01453385a001f8a 100644
--- a/components/cronet/android/cronet_library_loader.cc
+++ b/components/cronet/android/cronet_library_loader.cc
@@ -113,8 +113,8 @@ void CronetInitOnMainThread(JNIEnv* env, jclass jcaller) {
g_network_change_notifier = net::NetworkChangeNotifier::Create();
}
-jstring GetCronetVersion(JNIEnv* env, jclass jcaller) {
- return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION).Release();
+ScopedJavaLocalRef<jstring> GetCronetVersion(JNIEnv* env, jclass jcaller) {
+ return base::android::ConvertUTF8ToJavaString(env, CRONET_VERSION);
}
} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698