Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6224)

Unified Diff: chrome/browser/ui/android/certificate_viewer_android.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/certificate_viewer_android.cc
diff --git a/chrome/browser/ui/android/certificate_viewer_android.cc b/chrome/browser/ui/android/certificate_viewer_android.cc
index b990478831a7793406bb7d3dfc3a732a9e27f743..f4a1380441a94749e939b6a5123e1e43e50662b5 100644
--- a/chrome/browser/ui/android/certificate_viewer_android.cc
+++ b/chrome/browser/ui/android/certificate_viewer_android.cc
@@ -21,70 +21,71 @@ void ShowCertificateViewer(content::WebContents* web_contents,
NOTREACHED();
}
-static jstring GetCertIssuedToText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertIssuedToText(JNIEnv* env, jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_SUBJECT_GROUP)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_SUBJECT_GROUP));
}
-static jstring GetCertInfoCommonNameText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertInfoCommonNameText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_COMMON_NAME_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_COMMON_NAME_LABEL));
}
-static jstring GetCertInfoOrganizationText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertInfoOrganizationText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_ORGANIZATION_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ORGANIZATION_LABEL));
}
-static jstring GetCertInfoSerialNumberText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertInfoSerialNumberText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_SERIAL_NUMBER_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_SERIAL_NUMBER_LABEL));
}
-static jstring GetCertInfoOrganizationUnitText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertInfoOrganizationUnitText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_ORGANIZATIONAL_UNIT_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ORGANIZATIONAL_UNIT_LABEL));
}
-static jstring GetCertIssuedByText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertIssuedByText(JNIEnv* env, jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ISSUER_GROUP)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ISSUER_GROUP));
}
-static jstring GetCertValidityText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertValidityText(JNIEnv* env, jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_VALIDITY_GROUP)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_VALIDITY_GROUP));
}
-static jstring GetCertIssuedOnText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertIssuedOnText(JNIEnv* env, jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ISSUED_ON_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_ISSUED_ON_LABEL));
}
-static jstring GetCertExpiresOnText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertExpiresOnText(JNIEnv* env, jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(IDS_CERT_INFO_EXPIRES_ON_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_EXPIRES_ON_LABEL));
}
-static jstring GetCertFingerprintsText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertFingerprintsText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_FINGERPRINTS_GROUP)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_FINGERPRINTS_GROUP));
}
-static jstring GetCertSHA256FingerprintText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertSHA256FingerprintText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_SHA256_FINGERPRINT_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_SHA256_FINGERPRINT_LABEL));
}
-static jstring GetCertSHA1FingerprintText(JNIEnv* env, jclass) {
+static ScopedJavaLocalRef<jstring> GetCertSHA1FingerprintText(JNIEnv* env,
+ jclass) {
return ConvertUTF8ToJavaString(
- env, l10n_util::GetStringUTF8(
- IDS_CERT_INFO_SHA1_FINGERPRINT_LABEL)).Release();
+ env, l10n_util::GetStringUTF8(IDS_CERT_INFO_SHA1_FINGERPRINT_LABEL));
}
bool RegisterCertificateViewer(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698