Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2602)

Unified Diff: chrome/browser/invalidation/invalidation_service_factory_android.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/invalidation/invalidation_service_factory_android.cc
diff --git a/chrome/browser/invalidation/invalidation_service_factory_android.cc b/chrome/browser/invalidation/invalidation_service_factory_android.cc
index 821d702a6e817ab6f0538be5ab9e6a45f296205c..5058f680ad98c84d0549c6875c936a762a3591a8 100644
--- a/chrome/browser/invalidation/invalidation_service_factory_android.cc
+++ b/chrome/browser/invalidation/invalidation_service_factory_android.cc
@@ -16,34 +16,39 @@ using base::android::ScopedJavaLocalRef;
namespace invalidation {
-jobject InvalidationServiceFactoryAndroid::GetForProfile(JNIEnv* env,
- jclass clazz,
- jobject j_profile) {
+ScopedJavaLocalRef<jobject> InvalidationServiceFactoryAndroid::GetForProfile(
+ JNIEnv* env,
+ jclass clazz,
+ jobject j_profile) {
Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
invalidation::ProfileInvalidationProvider* provider =
ProfileInvalidationProviderFactory::GetForProfile(profile);
InvalidationServiceAndroid* service_android =
static_cast<InvalidationServiceAndroid*>(
provider->GetInvalidationService());
- return service_android->java_ref_.obj();
+ return ScopedJavaLocalRef<jobject>(service_android->java_ref_);
}
-jobject InvalidationServiceFactoryAndroid::GetForTest(JNIEnv* env,
- jclass clazz,
- jobject j_context) {
+ScopedJavaLocalRef<jobject> InvalidationServiceFactoryAndroid::GetForTest(
+ JNIEnv* env,
+ jclass clazz,
+ jobject j_context) {
InvalidationServiceAndroid* service_android =
new InvalidationServiceAndroid(j_context);
- return service_android->java_ref_.obj();
+ return ScopedJavaLocalRef<jobject>(service_android->java_ref_);
}
-jobject GetForProfile(JNIEnv* env, jclass clazz, jobject j_profile) {
- return InvalidationServiceFactoryAndroid::GetForProfile(
- env, clazz, j_profile);
+ScopedJavaLocalRef<jobject> GetForProfile(JNIEnv* env,
+ jclass clazz,
+ jobject j_profile) {
+ return InvalidationServiceFactoryAndroid::GetForProfile(env, clazz,
+ j_profile);
}
-jobject GetForTest(JNIEnv* env, jclass clazz, jobject j_context) {
- return InvalidationServiceFactoryAndroid::GetForTest(
- env, clazz, j_context);
+ScopedJavaLocalRef<jobject> GetForTest(JNIEnv* env,
+ jclass clazz,
+ jobject j_context) {
+ return InvalidationServiceFactoryAndroid::GetForTest(env, clazz, j_context);
}
bool InvalidationServiceFactoryAndroid::Register(JNIEnv* env) {

Powered by Google App Engine
This is Rietveld 408576698