chrome/browser/android/tab_state.h - Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_state.h

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some newlines for readability Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/profiles/profile_downloader_android.cc ('k') | chrome/browser/android/tab_state.cc » ('j') | chrome/browser/signin/oauth2_token_service_delegate_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/tab_state.h

diff --git a/chrome/browser/android/tab_state.h b/chrome/browser/android/tab_state.h

index 3f5f7361724556890b7f8c3dc0b13cdd122dd76d..2b0182a5dba914b583761146c7af5057caad2cd7 100644

--- a/chrome/browser/android/tab_state.h

+++ b/chrome/browser/android/tab_state.h

@@ -51,12 +51,12 @@ class WebContentsState {

bool initially_hidden);

// Restores a WebContents from the passed in state.

- static jobject RestoreContentsFromByteBuffer(

- JNIEnv* env,

- jclass clazz,

- jobject state,

- jint saved_state_version,

- jboolean initially_hidden);

+ static base::android::ScopedJavaLocalRef<jobject>

+ RestoreContentsFromByteBuffer(JNIEnv* env,

+ jclass clazz,

+ jobject state,

+ jint saved_state_version,

+ jboolean initially_hidden);

// Synthesizes a stub, single-navigation state for a tab that will be loaded

// lazily.