Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: base/android/jni_generator/testFromJavaP.golden

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/testFromJavaP.golden
diff --git a/base/android/jni_generator/testFromJavaP.golden b/base/android/jni_generator/testFromJavaP.golden
index b7276bc29383d5c623975bef5f75057c2943af6a..f32666c252960a8b1fac7993dc854cb328f54255 100644
--- a/base/android/jni_generator/testFromJavaP.golden
+++ b/base/android/jni_generator/testFromJavaP.golden
@@ -230,10 +230,9 @@ static jlong Java_InputStream_skip(JNIEnv* env, jobject obj, jlong p0) {
}
static base::subtle::AtomicWord g_InputStream_Constructor = 0;
-static base::android::ScopedJavaLocalRef<jobject>
- Java_InputStream_Constructor(JNIEnv* env) __attribute__ ((unused));
-static base::android::ScopedJavaLocalRef<jobject>
- Java_InputStream_Constructor(JNIEnv* env) {
+static ScopedJavaLocalRef<jobject> Java_InputStream_Constructor(JNIEnv* env)
+ __attribute__ ((unused));
+static ScopedJavaLocalRef<jobject> Java_InputStream_Constructor(JNIEnv* env) {
/* Must call RegisterNativesImpl() */
CHECK_CLAZZ(env, InputStream_clazz(env),
InputStream_clazz(env), NULL);
@@ -249,7 +248,7 @@ static base::android::ScopedJavaLocalRef<jobject>
env->NewObject(InputStream_clazz(env),
method_id);
jni_generator::CheckException(env);
- return base::android::ScopedJavaLocalRef<jobject>(env, ret);
+ return ScopedJavaLocalRef<jobject>(env, ret);
}
// Step 3: RegisterNatives.

Powered by Google App Engine
This is Rietveld 408576698