Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7469)

Unified Diff: base/android/jni_generator/sample_for_tests.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/sample_for_tests.cc
diff --git a/base/android/jni_generator/sample_for_tests.cc b/base/android/jni_generator/sample_for_tests.cc
index 61dd7f38eb2cf1c70ff83a34bee3ff5f6e67a498..a05909a46e66ab4976092a99a0018a070b16ab0c 100644
--- a/base/android/jni_generator/sample_for_tests.cc
+++ b/base/android/jni_generator/sample_for_tests.cc
@@ -81,8 +81,8 @@ static jfloat GetFloatFunction(JNIEnv*, jclass) {
static void SetNonPODDatatype(JNIEnv*, jobject, jobject) {
}
-static jobject GetNonPODDatatype(JNIEnv*, jobject) {
- return NULL;
+static ScopedJavaLocalRef<jobject> GetNonPODDatatype(JNIEnv*, jobject) {
+ return ScopedJavaLocalRef<jobject>();
}
static jint InnerFunction(JNIEnv*, jclass) {

Powered by Google App Engine
This is Rietveld 408576698