Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1453)

Unified Diff: android_webview/native/android_protocol_handler.cc

Issue 1288183004: jni_generator: Make all object-returning natives return ScopedJavaLocalRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add some newlines for readability Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/native/android_protocol_handler.cc
diff --git a/android_webview/native/android_protocol_handler.cc b/android_webview/native/android_protocol_handler.cc
index be3376cc976e0f2815e0d2b211c10e1ded01d171..e25b36dae3efbf402399c696361e81030e974742 100644
--- a/android_webview/native/android_protocol_handler.cc
+++ b/android_webview/native/android_protocol_handler.cc
@@ -281,16 +281,14 @@ static void SetResourceContextForTesting(JNIEnv* env, jclass /*clazz*/,
}
}
-static jstring GetAndroidAssetPath(JNIEnv* env, jclass /*clazz*/) {
- // OK to release, JNI binding.
- return ConvertUTF8ToJavaString(
- env, android_webview::kAndroidAssetPath).Release();
+static ScopedJavaLocalRef<jstring> GetAndroidAssetPath(JNIEnv* env,
+ jclass /*clazz*/) {
+ return ConvertUTF8ToJavaString(env, android_webview::kAndroidAssetPath);
}
-static jstring GetAndroidResourcePath(JNIEnv* env, jclass /*clazz*/) {
- // OK to release, JNI binding.
- return ConvertUTF8ToJavaString(
- env, android_webview::kAndroidResourcePath).Release();
+static ScopedJavaLocalRef<jstring> GetAndroidResourcePath(JNIEnv* env,
+ jclass /*clazz*/) {
+ return ConvertUTF8ToJavaString(env, android_webview::kAndroidResourcePath);
}
} // namespace android_webview

Powered by Google App Engine
This is Rietveld 408576698