Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1288153003: Stage sloppy classes (Closed)

Created:
5 years, 4 months ago by Dan Ehrenberg
Modified:
5 years, 4 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Stage sloppy classes This patch puts --harmony-sloppy into staging. Now that let, lexically-scoped functions and ES2015 sloppy mode const semantics have been split off into separate flags, the change only enables classes in sloppy mode. BUG=v8:3305 R=adamk LOG=Y Committed: https://crrev.com/9f9cb990a5ccd1514dd684293bbcb98e52031006 Cr-Commit-Position: refs/heads/master@{#30141}

Patch Set 1 #

Patch Set 2 : More test262 tests pass with sloppy class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -128 lines) Patch
M src/flag-definitions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 3 chunks +0 lines, -126 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Dan Ehrenberg
5 years, 4 months ago (2015-08-12 18:46:18 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288153003/1
5 years, 4 months ago (2015-08-12 18:46:30 UTC) #3
adamk
lgtm, but I think you're going to need to change a bunch of expectations for ...
5 years, 4 months ago (2015-08-12 19:13:04 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/8580)
5 years, 4 months ago (2015-08-12 19:19:08 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288153003/20001
5 years, 4 months ago (2015-08-12 23:05:45 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-12 23:39:36 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288153003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288153003/20001
5 years, 4 months ago (2015-08-12 23:40:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 23:42:12 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 23:42:32 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f9cb990a5ccd1514dd684293bbcb98e52031006
Cr-Commit-Position: refs/heads/master@{#30141}

Powered by Google App Engine
This is Rietveld 408576698