Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1288123004: Updating NaCl Revision to August 14th, 2015 (Closed)

Created:
5 years, 4 months ago by Sean Klein
Modified:
5 years, 4 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A + build/module_args/nacl.gni View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Sean Klein
Just making a small commit to get used to the Mojo code review process. PTAL ...
5 years, 4 months ago (2015-08-17 19:23:36 UTC) #2
jamesr
lgtm
5 years, 4 months ago (2015-08-17 19:24:48 UTC) #3
jamesr
Please put the exact committish in the commit message (that's a lot easier to parse ...
5 years, 4 months ago (2015-08-17 19:25:07 UTC) #4
Sean Klein
On 2015/08/17 19:25:07, jamesr wrote: > Please put the exact committish in the commit message ...
5 years, 4 months ago (2015-08-17 19:31:25 UTC) #5
jamesr
That's a bot issue, not your patch's fault
5 years, 4 months ago (2015-08-17 19:32:38 UTC) #6
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 4 months ago (2015-08-17 19:36:03 UTC) #9
Sean Klein
5 years, 4 months ago (2015-08-17 19:36:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
be881568b6d2af9a11cf7b83d889cb556b070344 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698