Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 12881014: When SkFlags encounters an invalid flag, quit. (Closed)

Created:
7 years, 9 months ago by scroggo
Modified:
7 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

When SkFlags encounters an invalid flag, quit. This way the user knows to change their command line. Committed: https://code.google.com/p/skia/source/detail?r=8275

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/SkFlags.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
7 years, 9 months ago (2013-03-20 19:58:57 UTC) #1
jvanverth1
lgtm
7 years, 9 months ago (2013-03-20 20:02:16 UTC) #2
scroggo
7 years, 9 months ago (2013-03-20 20:04:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r8275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698