Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1458)

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.h

Issue 12881005: Allow CopyFromBackingStore to fallback to copying from the renderer side if the accelerated surface… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/tabs/tabs_api.h
diff --git a/chrome/browser/extensions/api/tabs/tabs_api.h b/chrome/browser/extensions/api/tabs/tabs_api.h
index d60abfe4a26617c5e37a590d3f9493639c56bfeb..69e0adfb91bac147145ee3f0f572b4be78001835 100644
--- a/chrome/browser/extensions/api/tabs/tabs_api.h
+++ b/chrome/browser/extensions/api/tabs/tabs_api.h
@@ -174,8 +174,7 @@ class TabsDetectLanguageFunction : public AsyncExtensionFunction,
content::NotificationRegistrar registrar_;
DECLARE_EXTENSION_FUNCTION("tabs.detectLanguage", TABS_DETECTLANGUAGE)
};
-class TabsCaptureVisibleTabFunction : public AsyncExtensionFunction,
- public content::NotificationObserver {
+class TabsCaptureVisibleTabFunction : public AsyncExtensionFunction {
public:
static void RegisterUserPrefs(PrefRegistrySyncable* registry);
@@ -191,16 +190,14 @@ class TabsCaptureVisibleTabFunction : public AsyncExtensionFunction,
virtual ~TabsCaptureVisibleTabFunction() {}
virtual bool RunImpl() OVERRIDE;
virtual bool GetTabToCapture(content::WebContents** web_contents);
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
void SendResultFromBitmap(const SkBitmap& screen_capture);
private:
void CopyFromBackingStoreComplete(bool succeeded,
const SkBitmap& bitmap);
-
- content::NotificationRegistrar registrar_;
+ void GetSnapshotFromRendererComplete(bool succeeded,
sky 2013/03/22 19:39:22 Add descriptions for these methods.
+ const SkBitmap& bitmap);
+ void SendInternalError();
// The format (JPEG vs PNG) of the resulting image. Set in RunImpl().
ImageFormat image_format_;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/tabs/tabs_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698