ShortcutInfo::favicon is now a gfx::ImageFamily instead of gfx::Image.

chrome/browser/web_applications/web_app_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/web_applications/web_app_mac.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_logging.h"
 #include "base/mac/mac_util.h"
 #include "base/mac/scoped_cftyperef.h"
 #include "base/memory/scoped_nsobject.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/browser/web_applications/web_app.h"
 #include "chrome/common/chrome_paths_internal.h"
 #include "chrome/common/mac/app_mode_common.h"
 #include "content/public/browser/browser_thread.h"
 #include "grit/chromium_strings.h"
 #include "skia/ext/skia_utils_mac.h"
 #include "third_party/icon_family/IconFamily.h"
 #include "ui/base/l10n/l10n_util_mac.h"
+#include "ui/gfx/icon_family.h"
 #include "ui/gfx/image/image_skia.h"
 
 namespace {
 
 // Creates a NSBitmapImageRep from |bitmap|.
 NSBitmapImageRep* SkBitmapToImageRep(const SkBitmap& bitmap) {
   base::mac::ScopedCFTypeRef<CGColorSpaceRef> color_space(
       CGColorSpaceCreateWithName(kCGColorSpaceGenericRGB));
   NSImage* image = gfx::SkBitmapToNSImageWithColorSpace(
     bitmap, color_space.get());
@@ skipping 153 matching lines @@
   [plist setObject:GetBundleIdentifier(plist)
             forKey:base::mac::CFToNSCast(kCFBundleIdentifierKey)];
   [plist setObject:base::mac::FilePathToNSString(user_data_dir_)
             forKey:app_mode::kCrAppModeUserDataDirKey];
   [plist setObject:base::mac::FilePathToNSString(info_.profile_path.BaseName())
             forKey:app_mode::kCrAppModeProfileDirKey];
   return [plist writeToFile:plist_path atomically:YES];
 }
 
 bool WebAppShortcutCreator::UpdateIcon(const base::FilePath& app_path) const {
-  if (info_.favicon.IsEmpty())
+  if (info_.favicon.empty())
     return true;
 
   scoped_nsobject<IconFamily> icon_family([[IconFamily alloc] init]);
   bool image_added = false;
-  info_.favicon.ToImageSkia()->EnsureRepsForSupportedScaleFactors();
-  std::vector<gfx::ImageSkiaRep> image_reps =
-      info_.favicon.ToImageSkia()->image_reps();
-  for (size_t i = 0; i < image_reps.size(); ++i) {
-    NSBitmapImageRep* image_rep = SkBitmapToImageRep(
-        image_reps[i].sk_bitmap());
+  for (gfx::IconFamily::const_iterator it = info_.favicon.begin();
+       it != info_.favicon.end(); ++it) {
+    // TODO(mgiuca): Do we want to do this? DO NOT SUBMIT.
+    // it->EnsureRepsForSupportedScaleFactors();
+    const SkBitmap& bitmap = *it->bitmap();
+    NSBitmapImageRep* image_rep = SkBitmapToImageRep(bitmap);

[pkotwicz, 2013/03/20 22:19:52]

There is one case where |favicon| can have an ImageSkiaRep with a scale factor
other than 1x.
FaviconTabHelper::GetFavicon() in GetShortcutInfoForTab() will return a favicon
with all of the supported scale factors.
The rule of thumb is that each call to ImageSkia::image_reps() requires a
preceding call to ImageSkia::EnsureRepsForSupportedScaleFactors().

     if (!image_rep)
       continue;
 
     // Missing an icon size is not fatal so don't fail if adding the bitmap
     // doesn't work.
     if (!AddBitmapImageRepToIconFamily(icon_family, image_rep))
       continue;
 
     image_added = true;
   }
@@ skipping 79 matching lines @@
 void UpdatePlatformShortcuts(
     const base::FilePath& web_app_path,
     const ShellIntegration::ShortcutInfo& shortcut_info) {
   // TODO(benwells): Implement this when shortcuts / weblings are enabled on
   // mac.
 }
 
 }  // namespace internals
 
 }  // namespace web_app