rAc Wallet extirpation round 4: clean out RPC code

rAc Wallet extirpation round 4: clean out RPC code

A few files remain:
- wallet::Address and FullWallet are still needed until Android references
  are cleaned up
- wallet_service_url is still used for ZI (although this could probably be
  moved into a different directory, either core/browser/wallet or
  chrome/browser/ or something)
- real_pan_wallet_client_unittest doesn't belong in this dir but whatever

BUG=521733
Committed: https://crrev.com/36d868c4941f9f62149356c444b119d12eb0e2f1
Cr-Commit-Position: refs/heads/master@{#344364}

[Evan Stade, 2015-08-19 19:14:41]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org

[Evan Stade, 2015-08-19 19:14:42]

depends on round 3 (you can see trybot output in PS#2)

[Dan Beam, 2015-08-19 19:25:02]

lgtm

damn wallet integration was a lot of code

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/full_wallet.cc (right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet.cc:38:
DCHECK(billing_address_.get());
nit: drop the .get(), it's cleaner

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet.cc:45:
FullWallet::CreateFullWalletFromClearText(
nit: scoped_ptr<FullWallet> FullWallet::CreateFullWalletFromClearText(

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/full_wallet_unittest.cc (right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet_unittest.cc:21: class
FullWalletTest : public testing::Test {
nit: typedef testing::Test FullWalletTest;

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet_unittest.cc:28:
TEST_F(FullWalletTest, RestLengthCorrectDecryptionTest) {
any reason these need to be TEST_F() now that there's no useful F?

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/wallet_items.cc (left):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/wallet_items.cc:30: // TODO(estade):
move to base/.
dodged that bullet (or do now?)

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/wallet_service_url_unittest.cc
(right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/wallet_service_url_unittest.cc:18:
return GetManageAddressesUrl(1).GetWithEmptyPath() ==
GURL("https://wallet.google.com/");
80 col

[Evan Stade, 2015-08-19 19:37:35]

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/full_wallet_unittest.cc (right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet_unittest.cc:28:
TEST_F(FullWalletTest, RestLengthCorrectDecryptionTest) {
On 2015/08/19 19:25:02, Dan Beam wrote:
> any reason these need to be TEST_F() now that there's no useful F?

Yes, it's because I don't want to take time to update code that should be
deleted ASAP anyway (this response applies to most of your comments on this CL)

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/wallet_service_url_unittest.cc
(right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/wallet_service_url_unittest.cc:18:
return GetManageAddressesUrl(1).GetWithEmptyPath() ==
GURL("https://wallet.google.com/");
On 2015/08/19 19:25:02, Dan Beam wrote:
> 80 col

wonder why presubmit isn't on for this directory

[Dan Beam, 2015-08-19 19:38:26]

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
File components/autofill/content/browser/wallet/full_wallet_unittest.cc (right):

https://codereview.chromium.org/1288093004/diff/40001/components/autofill/con...
components/autofill/content/browser/wallet/full_wallet_unittest.cc:28:
TEST_F(FullWalletTest, RestLengthCorrectDecryptionTest) {
On 2015/08/19 19:37:35, Evan Stade wrote:
> On 2015/08/19 19:25:02, Dan Beam wrote:
> > any reason these need to be TEST_F() now that there's no useful F?
> 
> Yes, it's because I don't want to take time to update code that should be
> deleted ASAP anyway (this response applies to most of your comments on this
CL)

aight that's cool, kill it instead

[Evan Stade, 2015-08-19 21:37:55]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-08-19 21:37:56]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1288093004/#ps60001
(title: "git cl format")

[commit-bot: I haz the power, 2015-08-19 21:38:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288093004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288093004/60001

[commit-bot: I haz the power, 2015-08-19 21:48:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-19 21:48:32]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-08-19 22:10:03]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-08-19 22:10:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1288093004/#ps80001
(title: "fix gn")

[commit-bot: I haz the power, 2015-08-19 22:10:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1288093004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1288093004/80001

[commit-bot: I haz the power, 2015-08-20 00:05:36]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-08-20 00:06:11]

Patchset 5 (id:??) landed as
https://crrev.com/36d868c4941f9f62149356c444b119d12eb0e2f1
Cr-Commit-Position: refs/heads/master@{#344364}