Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288073005: Make the ChromeOS chromecast system tray integration use a private API. (Closed)

Created:
5 years, 4 months ago by jdufault
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the ChromeOS chromecast system tray integration use a private API. This is a combination of two code review's which have circular dependencies: - http://crrev.com/1291113002 - http://crrev.com/1291703010 R=rockot@chromium.org,kalman@chromium.org,isherman@chromium.org,oshima@chromium.org,achuith@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/1dd545e06b6bff83b083948f1d72e941fb87c463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -244 lines) Patch
M ash/cast_config_delegate.h View 4 chunks +18 lines, -11 lines 0 comments Download
M ash/system/cast/tray_cast.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 16 chunks +111 lines, -132 lines 0 comments Download
A chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.h View 1 chunk +71 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/cast_config_delegate_chromeos.cc View 4 chunks +41 lines, -96 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/common/extensions/api/cast_devices_private.idl View 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/extension_event_histogram_value.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/_permission_features.json View 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288073005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288073005/1
5 years, 4 months ago (2015-08-20 19:00:00 UTC) #2
commit-bot: I haz the power
Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even ...
5 years, 4 months ago (2015-08-20 19:00:02 UTC) #4
achuithb
5 years, 4 months ago (2015-08-21 03:22:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
1dd545e06b6bff83b083948f1d72e941fb87c463.

Powered by Google App Engine
This is Rietveld 408576698