Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1288073003: Inline default false setting for unifiedTextCheckerEnabled setting. (Closed)

Created:
5 years, 4 months ago by jbroman
Modified:
5 years, 4 months ago
Reviewers:
Yuta Kitamura
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Inline default false setting for unifiedTextCheckerEnabled setting. The default has been false for at least two years now. Chromium can turn it on, but it's appropriate for the initial value to be inlined into Settings.in, like most of the default-off settings. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201065

Patch Set 1 #

Patch Set 2 : merge conflict #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M Source/core/frame/Settings.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/Settings.in View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jbroman
This setting's default looks like it can just go in Settings.in rather than Settings.cpp, like ...
5 years, 4 months ago (2015-08-22 05:57:08 UTC) #2
Yuta Kitamura
lgtm
5 years, 4 months ago (2015-08-24 04:00:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288073003/20001
5 years, 4 months ago (2015-08-24 14:10:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/97462)
5 years, 4 months ago (2015-08-24 15:57:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288073003/20001
5 years, 4 months ago (2015-08-24 15:59:23 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-24 17:00:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201065

Powered by Google App Engine
This is Rietveld 408576698