Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1288063008: Move parentEditingBoundary() to VisibileUnits.cpp from Position.cpp. (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move parentEditingBoundary() to VisibileUnits.cpp from Position.cpp. This patch moves |parentEditingBoundary()| to "VisibleUnits.{cpp,h}" from "Position.{cpp,h}" with |nonShadowBoundaryParentNode()| which is used only by |parentEditingBoundary()| to cleanup "Position.{cpp,h}" for improving code health, since |parentEditingBoundary()| is used only in "VisibleUnits.cpp". BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200907

Patch Set 1 : 2015-08-20T17:32 #

Patch Set 2 : 2015-08-20T22:51:43 Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -40 lines) Patch
M Source/core/editing/Position.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 1 chunk +0 lines, -35 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-20 09:21:29 UTC) #2
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-20 11:07:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063008/1
5 years, 4 months ago (2015-08-20 11:22:16 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/90590)
5 years, 4 months ago (2015-08-20 11:26:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063008/20001
5 years, 4 months ago (2015-08-20 13:52:28 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 15:52:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200907

Powered by Google App Engine
This is Rietveld 408576698