Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1288063006: Move GuestView code from WebView-specific web_view_iframe.js into (Closed)

Created:
5 years, 4 months ago by lfg
Modified:
5 years, 4 months ago
Reviewers:
paulmeyer
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move GuestView code from WebView-specific web_view_iframe.js into guest_view_iframe_container.js. BUG=330264 Committed: https://crrev.com/51da06d54ae07a7ca1f9432fa72e6d4b515b392f Cr-Commit-Position: refs/heads/master@{#343933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -19 lines) Patch
M extensions/renderer/resources/guest_view/guest_view_iframe_container.js View 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/renderer/resources/guest_view/web_view/web_view_iframe.js View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
lfg
Hey Paul, please take a look!
5 years, 4 months ago (2015-08-17 21:23:45 UTC) #2
paulmeyer
On 2015/08/17 21:23:45, lfg wrote: > Hey Paul, please take a look! LGTM!
5 years, 4 months ago (2015-08-17 21:56:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063006/1
5 years, 4 months ago (2015-08-18 15:46:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-18 16:20:06 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 16:20:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/51da06d54ae07a7ca1f9432fa72e6d4b515b392f
Cr-Commit-Position: refs/heads/master@{#343933}

Powered by Google App Engine
This is Rietveld 408576698