Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1288063002: SkPDF: Move SkFlate into src/pdf (part 3/3) (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: Move SkFlate into src/pdf (part 3/3) This must land after http://crrev.com/1288053002 Motivation: Skia only uses SkFlate in the SkPDF module. Committed: https://skia.googlesource.com/skia/+/f5fb939867405eabdeaff6e10948d9dd9317d1b5

Patch Set 1 #

Patch Set 2 : 2015-08-12 (Wednesday) 18:23:41 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
D src/core/SkFlate.h View 1 1 chunk +0 lines, -7 lines 0 comments Download
D src/core/SkFlate.cpp View 1 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
hal.canary
PTAL
5 years, 4 months ago (2015-08-12 15:37:31 UTC) #2
reed1
lgtm
5 years, 4 months ago (2015-08-12 15:47:00 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063002/20001
5 years, 4 months ago (2015-08-14 18:17:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-14 18:24:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288063002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288063002/20001
5 years, 4 months ago (2015-08-14 18:26:01 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 18:26:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f5fb939867405eabdeaff6e10948d9dd9317d1b5

Powered by Google App Engine
This is Rietveld 408576698