Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 128803002: Mojo: Remove utility:: namespace (Closed)

Created:
6 years, 11 months ago by darin (slow to review)
Modified:
6 years, 11 months ago
Reviewers:
viettrungluu, sky
CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium, sky, DaveMoore
Visibility:
Public.

Description

Mojo: Remove utility:: namespace Public facing APIs should just live in the mojo:: namespace. R=sky@chromium.org, viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243799

Patch Set 1 #

Patch Set 2 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M mojo/examples/sample_app/sample_app.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/utility/bindings_support_impl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/bindings_support_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/bindings_support_impl_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/environment.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/environment.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/run_loop.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/run_loop.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/run_loop_handler.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/run_loop_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/thread_local.h View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/thread_local_posix.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/public/utility/thread_local_win.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
darin (slow to review)
6 years, 11 months ago (2014-01-08 17:59:52 UTC) #1
viettrungluu
lgtm
6 years, 11 months ago (2014-01-08 19:00:27 UTC) #2
sky
LGTM
6 years, 11 months ago (2014-01-08 21:01:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/128803002/1
6 years, 11 months ago (2014-01-08 22:38:41 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243765
6 years, 11 months ago (2014-01-09 01:27:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/128803002/290001
6 years, 11 months ago (2014-01-09 04:57:22 UTC) #6
darin (slow to review)
6 years, 11 months ago (2014-01-09 07:40:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r243799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698