Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 12880013: Move parsing code from gdata_wapi_service to gdata_wapi_operations. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

Move parsing code from gdata_wapi_service to gdata_wapi_operations. This is preparation to use the operation in Drive API v2, as a workaround of not-yet-implemented operation (authorizing third party apps). BUG=179837 TEST=Ran unit_tests and tested chromeos-chrome manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190421

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -41 lines) Patch
M chrome/browser/google_apis/gdata_wapi_operations.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations.cc View 2 chunks +38 lines, -2 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_operations_unittest.cc View 1 3 chunks +2 lines, -9 lines 0 comments Download
M chrome/browser/google_apis/gdata_wapi_service.cc View 2 chunks +1 line, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-03-25 11:59:05 UTC) #1
kinaba
lgtm
7 years, 9 months ago (2013-03-25 12:07:31 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/12880013/diff/1005/chrome/browser/google_apis/gdata_wapi_operations.h File chrome/browser/google_apis/gdata_wapi_operations.h (right): https://codereview.chromium.org/12880013/diff/1005/chrome/browser/google_apis/gdata_wapi_operations.h#newcode266 chrome/browser/google_apis/gdata_wapi_operations.h:266: // by |app_id| to access a document specified ...
7 years, 9 months ago (2013-03-25 12:11:24 UTC) #3
hidehiko
Thank you for your review. Sending to CQ. https://codereview.chromium.org/12880013/diff/1005/chrome/browser/google_apis/gdata_wapi_operations.h File chrome/browser/google_apis/gdata_wapi_operations.h (right): https://codereview.chromium.org/12880013/diff/1005/chrome/browser/google_apis/gdata_wapi_operations.h#newcode266 chrome/browser/google_apis/gdata_wapi_operations.h:266: // ...
7 years, 9 months ago (2013-03-25 12:41:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/12880013/4005
7 years, 9 months ago (2013-03-25 12:41:46 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-25 16:48:26 UTC) #6
Message was sent while issue was closed.
Change committed as 190421

Powered by Google App Engine
This is Rietveld 408576698