Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/full-codegen/mips64/full-codegen-mips64.cc

Issue 1287983002: [compiler] Remove broken support for undetectable strings. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_MIPS64 7 #if V8_TARGET_ARCH_MIPS64
8 8
9 // Note on Mips implementation: 9 // Note on Mips implementation:
10 // 10 //
(...skipping 5041 matching lines...) Expand 10 before | Expand all | Expand 10 after
5052 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false); 5052 PrepareForBailoutBeforeSplit(expr, true, if_true, if_false);
5053 5053
5054 Factory* factory = isolate()->factory(); 5054 Factory* factory = isolate()->factory();
5055 if (String::Equals(check, factory->number_string())) { 5055 if (String::Equals(check, factory->number_string())) {
5056 __ JumpIfSmi(v0, if_true); 5056 __ JumpIfSmi(v0, if_true);
5057 __ ld(v0, FieldMemOperand(v0, HeapObject::kMapOffset)); 5057 __ ld(v0, FieldMemOperand(v0, HeapObject::kMapOffset));
5058 __ LoadRoot(at, Heap::kHeapNumberMapRootIndex); 5058 __ LoadRoot(at, Heap::kHeapNumberMapRootIndex);
5059 Split(eq, v0, Operand(at), if_true, if_false, fall_through); 5059 Split(eq, v0, Operand(at), if_true, if_false, fall_through);
5060 } else if (String::Equals(check, factory->string_string())) { 5060 } else if (String::Equals(check, factory->string_string())) {
5061 __ JumpIfSmi(v0, if_false); 5061 __ JumpIfSmi(v0, if_false);
5062 // Check for undetectable objects => false.
5063 __ GetObjectType(v0, v0, a1); 5062 __ GetObjectType(v0, v0, a1);
5064 __ Branch(if_false, ge, a1, Operand(FIRST_NONSTRING_TYPE)); 5063 Split(lt, a1, Operand(FIRST_NONSTRING_TYPE), if_true, if_false,
5065 __ lbu(a1, FieldMemOperand(v0, Map::kBitFieldOffset)); 5064 fall_through);
5066 __ And(a1, a1, Operand(1 << Map::kIsUndetectable));
5067 Split(eq, a1, Operand(zero_reg),
5068 if_true, if_false, fall_through);
5069 } else if (String::Equals(check, factory->symbol_string())) { 5065 } else if (String::Equals(check, factory->symbol_string())) {
5070 __ JumpIfSmi(v0, if_false); 5066 __ JumpIfSmi(v0, if_false);
5071 __ GetObjectType(v0, v0, a1); 5067 __ GetObjectType(v0, v0, a1);
5072 Split(eq, a1, Operand(SYMBOL_TYPE), if_true, if_false, fall_through); 5068 Split(eq, a1, Operand(SYMBOL_TYPE), if_true, if_false, fall_through);
5073 } else if (String::Equals(check, factory->boolean_string())) { 5069 } else if (String::Equals(check, factory->boolean_string())) {
5074 __ LoadRoot(at, Heap::kTrueValueRootIndex); 5070 __ LoadRoot(at, Heap::kTrueValueRootIndex);
5075 __ Branch(if_true, eq, v0, Operand(at)); 5071 __ Branch(if_true, eq, v0, Operand(at));
5076 __ LoadRoot(at, Heap::kFalseValueRootIndex); 5072 __ LoadRoot(at, Heap::kFalseValueRootIndex);
5077 Split(eq, v0, Operand(at), if_true, if_false, fall_through); 5073 Split(eq, v0, Operand(at), if_true, if_false, fall_through);
5078 } else if (String::Equals(check, factory->undefined_string())) { 5074 } else if (String::Equals(check, factory->undefined_string())) {
(...skipping 333 matching lines...) Expand 10 before | Expand all | Expand 10 after
5412 reinterpret_cast<uint64_t>( 5408 reinterpret_cast<uint64_t>(
5413 isolate->builtins()->OsrAfterStackCheck()->entry())); 5409 isolate->builtins()->OsrAfterStackCheck()->entry()));
5414 return OSR_AFTER_STACK_CHECK; 5410 return OSR_AFTER_STACK_CHECK;
5415 } 5411 }
5416 5412
5417 5413
5418 } // namespace internal 5414 } // namespace internal
5419 } // namespace v8 5415 } // namespace v8
5420 5416
5421 #endif // V8_TARGET_ARCH_MIPS64 5417 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW
« no previous file with comments | « src/full-codegen/mips/full-codegen-mips.cc ('k') | src/full-codegen/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698