Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: Source/platform/heap/Visitor.h

Issue 1287963002: Fix race at blink::GCInfoAtBase<T>::index (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@oilpan_1
Patch Set: Adding assert. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Visitor.h
diff --git a/Source/platform/heap/Visitor.h b/Source/platform/heap/Visitor.h
index 83b5f85b6d40556413df4d6011ba68f3b99c49ed..fdca774a3e2528c7660bf862efa061031a7abbc9 100644
--- a/Source/platform/heap/Visitor.h
+++ b/Source/platform/heap/Visitor.h
@@ -41,6 +41,7 @@
#include "wtf/Forward.h"
#include "wtf/HashMap.h"
#include "wtf/HashTraits.h"
+#include "wtf/MainThread.h"
#include "wtf/TypeTraits.h"
#if ENABLE(GC_PROFILING)
#include "wtf/InstanceCounter.h"
@@ -390,6 +391,7 @@ template<typename T>
struct TypenameStringTrait {
static const String& get()
{
+ ASSERT(isMainThread());
haraken 2015/08/12 12:33:41 It is not guaranteed that get() is called only by
DEFINE_STATIC_LOCAL(String, typenameString, (WTF::extractTypeNameFromFunctionName(WTF::extractNameFunction<T>())));
return typenameString;
}
« no previous file with comments | « Source/platform/heap/GCInfo.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698