Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Issue 1287943006: Remove the array of Provider Names and Provider Source and replace with a map. (Closed)

Created:
5 years, 4 months ago by Deepak
Modified:
5 years, 4 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, markusheintz_, raymes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the array of Provider Names and Provider Source and replace with a map. Provider Names and Provider Source are in the form of seprate array. map usage will make it better readability and maintainability. BUG=520352 Committed: https://crrev.com/179fa2991dbcf898490ff86688a628ffaa5af563 Cr-Commit-Position: refs/heads/master@{#343188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -28 lines) Patch
M components/content_settings/core/browser/host_content_settings_map.cc View 6 chunks +23 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Deepak
PTAL
5 years, 4 months ago (2015-08-13 04:28:20 UTC) #2
Bernhard Bauer
LGTM, thanks!
5 years, 4 months ago (2015-08-13 13:26:25 UTC) #3
Deepak
On 2015/08/13 13:26:25, Bernhard Bauer wrote: > LGTM, thanks! Thanks.
5 years, 4 months ago (2015-08-13 13:28:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287943006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287943006/1
5 years, 4 months ago (2015-08-13 13:28:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 13:33:39 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 13:34:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/179fa2991dbcf898490ff86688a628ffaa5af563
Cr-Commit-Position: refs/heads/master@{#343188}

Powered by Google App Engine
This is Rietveld 408576698