fix gm self-test

gm/tests/run.sh

 #!/bin/bash
 
 # Self-tests for gm, based on tools/tests/run.sh
 #
 # These tests are run by the Skia_PerCommit_House_Keeping bot at every commit,
 # so make sure that they still pass when you make changes to gm!
 #
 # To generate new baselines when gm behavior changes, run gm/tests/rebaseline.sh
 #
 # TODO: because this is written as a shell script (instead of, say, Python)

[epoger, 2014/01/08 17:59:10]

The long-term fix is to re-write the GM self-test:
- in Python : https://code.google.com/p/skia/issues/detail?id=677
- so it is less fragile : https://code.google.com/p/skia/issues/detail?id=1068

But for now, I want to turn this step from red to green with the tiny fix below.

 # it only runs on Linux and Mac.
 # See https://code.google.com/p/skia/issues/detail?id=677
 # ('make tools/tests/run.sh work cross-platform')
 # Ideally, these tests should pass on all development platforms...
 # otherwise, how can developers be expected to test them before committing a
 # change?
 
 # cd into .../trunk so all the paths will work
 cd $(dirname $0)/../..
 
@@ skipping 77 matching lines @@
   # Python soon, and make stuff like this more maintainable.
   grep ^GM: $ACTUAL_OUTPUT_DIR/stdout >$ACTUAL_OUTPUT_DIR/stdout-tmp
   mv $ACTUAL_OUTPUT_DIR/stdout-tmp $ACTUAL_OUTPUT_DIR/stdout
   grep ^GM: $ACTUAL_OUTPUT_DIR/stderr >$ACTUAL_OUTPUT_DIR/stderr-tmp
   mv $ACTUAL_OUTPUT_DIR/stderr-tmp $ACTUAL_OUTPUT_DIR/stderr
 
   # Replace image file contents with just the filename, for two reasons:
   # 1. Image file encoding may vary by platform
   # 2. https://code.google.com/p/chromium/issues/detail?id=169600
   #    ('gcl/upload.py fail to upload binary files to rietveld')
-  for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name *.png); do
+  for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name \*.png); do
     echo "[contents of $IMAGEFILE]" >$IMAGEFILE
   done
-  for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name *.pdf); do
+  for IMAGEFILE in $(find $ACTUAL_OUTPUT_DIR -name \*.pdf); do
     echo "[contents of $IMAGEFILE]" >$IMAGEFILE
   done
 
   # Add a file to any empty subdirectories.
   for DIR in $(find $ACTUAL_OUTPUT_DIR -mindepth 1 -type d); do
     echo "Created additional file to make sure directory isn't empty, because self-test cannot handle empty directories." >$DIR/bogusfile
   done
 
   compare_directories $EXPECTED_OUTPUT_DIR $ACTUAL_OUTPUT_DIR
 }
@@ skipping 136 matching lines @@
 for CASE in $FAILING_CASES; do
   assert_fails "python gm/display_json_results.py $GM_OUTPUTS/$CASE/$OUTPUT_EXPECTED_SUBDIR/json-summary.txt"
 done
 
 if [ $ENCOUNTERED_ANY_ERRORS == 0 ]; then
   echo "All tests passed."
   exit 0
 else
   exit 1
 fi