chrome/browser/extensions/api/settings_private/settings_private_delegate.h - Issue 1287913005: Refactor prefs.js for MD-Settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/settings_private/settings_private_delegate.h

Issue 1287913005: Refactor prefs.js for MD-Settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update after meeting Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/settings_private/settings_private_api.cc ('K') | « chrome/browser/extensions/api/settings_private/settings_private_api.cc ('k') | chrome/browser/extensions/api/settings_private/settings_private_delegate.cc » ('j') | chrome/browser/resources/settings/checkbox/checkbox.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/settings_private/settings_private_delegate.h

diff --git a/chrome/browser/extensions/api/settings_private/settings_private_delegate.h b/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

index b2a1c90c75c1c9c2c946f0857c3aada50e96ffe2..3f6c6ba5a37bb403729a5e5583ac54d144645a65 100644

--- a/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

+++ b/chrome/browser/extensions/api/settings_private/settings_private_delegate.h

@@ -35,7 +35,8 @@ class SettingsPrivateDelegate : public KeyedService {

~SettingsPrivateDelegate() override;

// Sets the pref with the given name and value in the proper PrefService.

- virtual bool SetPref(const std::string& name, const base::Value* value);

+ virtual PrefsUtil::SetPrefResult SetPref(

+ const std::string& name, const base::Value* value);

// Gets the value of the pref with the given |name|.

virtual scoped_ptr<base::Value> GetPref(const std::string& name);