Refactor prefs.js for MD-Settings

chrome/browser/extensions/api/settings_private/settings_private_api.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/settings_private/settings_private_api.h"
 
 #include "base/values.h"
 #include "chrome/browser/extensions/api/settings_private/settings_private_delegate.h"
 #include "chrome/browser/extensions/api/settings_private/settings_private_delegate_factory.h"
 #include "chrome/browser/extensions/chrome_extension_function.h"
@@ skipping 11 matching lines @@
 }
 
 ExtensionFunction::ResponseAction SettingsPrivateSetPrefFunction::Run() {
   scoped_ptr<api::settings_private::SetPref::Params> parameters =
       api::settings_private::SetPref::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(parameters.get());
 
   SettingsPrivateDelegate* delegate =
       SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context());
 
-  return RespondNow(OneArgument(new base::FundamentalValue(
-      delegate->SetPref(parameters->name, parameters->value.get()))));
+  PrefsUtil::SetPrefResult result =
+      delegate->SetPref(parameters->name, parameters->value.get());
+  switch (result) {
+    case PrefsUtil::SUCCESS:
+      return RespondNow(OneArgument(new base::FundamentalValue(true)));
+    case PrefsUtil::PREF_NOT_MODIFIABLE:
+      // Not an error, but return false to indicate setting the pref failed.
+      return RespondNow(OneArgument(new base::FundamentalValue(false)));
+    default:
+      // Indicates a problem with the function call.
+      return RespondNow(Error("Error setting pref *", parameters->name));

[stevenjb, 2015/08/26 17:32:18]

Since we went to the trouble to define the different failure types, we should
set Error to "not_found", etc.

[michaelpg, 2015/08/26 23:32:15]

Done.

+  }
 }
 
 
 ////////////////////////////////////////////////////////////////////////////////
 // SettingsPrivateGetAllPrefsFunction
 ////////////////////////////////////////////////////////////////////////////////
 
 SettingsPrivateGetAllPrefsFunction::~SettingsPrivateGetAllPrefsFunction() {
 }
 
@@ skipping 20 matching lines @@
       SettingsPrivateDelegateFactory::GetForBrowserContext(browser_context());
 
   scoped_ptr<base::Value> value = delegate->GetPref(parameters->name);
   if (value->IsType(base::Value::TYPE_NULL))
     return RespondNow(Error("Pref * does not exist", parameters->name));
   else
     return RespondNow(OneArgument(value.release()));
 }
 
 }  // namespace extensions