Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1287903002: Revert of [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher (Closed)

Created:
5 years, 4 months ago by falken
Modified:
5 years, 4 months ago
Reviewers:
annekao, Devlin, sadrul, dcheng
CC:
blink-reviews, blink-worker-reviews_chromium.org, dglazkov+blink, horo+watch_chromium.org, not at google - send to devlin, kinuko+worker_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher (patchset #5 id:190001 of https://codereview.chromium.org/1264913002/ ) Reason for revert: Sorry to revert this change. It's suspected of breaking webkit_unit_tests test CompositorWorkerManagerTest.CreatingSecondDuringTerminationOfFirst: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/39874 Original issue's description: > [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher > > Pass the v8::context from the worker thread up to the extensions dispatcher. > > In order to expose any kind of custom binding (i.e., javascript callback into C++ code) for the service worker context, we need to be alerted of when the context is created, so that we can inject them. For most contexts, this is done through the blink notification (didCreateScriptContext), but that doesn't cover > worker contexts. > > Please view https://codereview.chromium.org/1256323008/ for the continuation of this implementation in chrome. > > BUG=501569 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200277 TBR=dcheng@chromium.org,rdevlin.cronin@chromium.org,sadrul@chromium.org,annekao@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=501569 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200376

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M Source/core/workers/WorkerReportingProxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
falken
Created Revert of [Extension ServiceWorkers] Blink: Passing v8::context to extensions dispatcher
5 years, 4 months ago (2015-08-12 03:17:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287903002/1
5 years, 4 months ago (2015-08-12 03:17:29 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 03:18:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200376

Powered by Google App Engine
This is Rietveld 408576698