Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 12879010: GpuVideoDecoder: fix OS_WIN define. (Closed)

Created:
7 years, 9 months ago by scherkus (not reviewing)
Modified:
7 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Pawel Osciak
Visibility:
Public.

Description

GpuVideoDecoder: fix OS_WIN define. We now properly skip hardware decoding of >1920x1080 videos on Windows. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189437

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
posciak/fischman: I guess the check was never working on Windows? Refer to https://groups.google.com/a/chromium.org/d/msg/chromium-dev/YotqWMHq60g/dEK9INL4x84J
7 years, 9 months ago (2013-03-19 21:46:33 UTC) #1
DaleCurtis
Hah, I did the same thing, https://codereview.chromium.org/12478012 was waiting for Ami to reply :)
7 years, 9 months ago (2013-03-19 21:52:47 UTC) #2
Ami GONE FROM CHROMIUM
LGTM but be good to test on the original video that triggered this code (vimeo.com/49742318 ...
7 years, 9 months ago (2013-03-19 22:19:50 UTC) #3
scherkus (not reviewing)
On 2013/03/19 22:19:50, Ami Fischman wrote: > LGTM but be good to test on the ...
7 years, 9 months ago (2013-03-19 22:28:55 UTC) #4
scherkus (not reviewing)
On 2013/03/19 22:28:55, scherkus wrote: > On 2013/03/19 22:19:50, Ami Fischman wrote: > > LGTM ...
7 years, 9 months ago (2013-03-20 17:20:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scherkus@chromium.org/12879010/1
7 years, 9 months ago (2013-03-20 17:24:57 UTC) #6
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 22:36:05 UTC) #7
Message was sent while issue was closed.
Change committed as 189437

Powered by Google App Engine
This is Rietveld 408576698