Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1287893006: Separate UnicodeCache out into an own file. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Separate UnicodeCache out into an own file. This make inclusion of unicode-inl.h in object.h absolete. Now most compilation units don't require that header. It also breaks a cycle within declarations of the scanner.h header. This tries to remove includes of "-inl.h" headers from normal ".h" headers, thereby reducing the chance of any cyclic dependencies and decreasing the average size of our compilation units. Note that this change still leaves 3 violations of that rule in the code, checked with the "tools/check-inline-includes.sh" tool. R=yangguo@chromium.org Committed: https://crrev.com/4e39437a027f62af700336421a5243fff9978d34 Cr-Commit-Position: refs/heads/master@{#30268}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -58 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/conversions-inl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/dateparser.h View 1 chunk +2 lines, -18 lines 0 comments Download
M src/dateparser-inl.h View 2 chunks +24 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/scanner.h View 2 chunks +1 line, -39 lines 0 comments Download
A src/unicode-cache.h View 1 chunk +47 lines, -0 lines 0 comments Download
A src/unicode-cache-inl.h View 1 chunk +49 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-20 11:11:36 UTC) #1
Yang
On 2015/08/20 11:11:36, Michael Starzinger wrote: lgtm.
5 years, 4 months ago (2015-08-20 11:23:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287893006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287893006/1
5 years, 4 months ago (2015-08-20 11:28:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-20 11:47:01 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 11:47:18 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4e39437a027f62af700336421a5243fff9978d34
Cr-Commit-Position: refs/heads/master@{#30268}

Powered by Google App Engine
This is Rietveld 408576698