Source/platform/graphics/paint/DisplayItemList.h - Issue 1287863003: Avoid re-iterate out-of-order display items

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/paint/DisplayItemList.h

Issue 1287863003: Avoid re-iterate out-of-order display items (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address pdr's comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/graphics/paint/DisplayItem.h ('K') | « Source/platform/graphics/paint/DisplayItem.h ('k') | Source/platform/graphics/paint/DisplayItemList.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/paint/DisplayItemList.h

diff --git a/Source/platform/graphics/paint/DisplayItemList.h b/Source/platform/graphics/paint/DisplayItemList.h

index a6780c4ef636ec2561e1f1cc0e596c5edf6bc746..1f81941ce5ba0c2e6773ce6aabc10a10b8ce7016 100644

--- a/Source/platform/graphics/paint/DisplayItemList.h

+++ b/Source/platform/graphics/paint/DisplayItemList.h

@@ -141,8 +141,8 @@ private:

static size_t findMatchingItemFromIndex(const DisplayItem::Id&, const DisplayItemIndicesByClientMap&, const DisplayItems&);

static void addItemToIndexIfNeeded(const DisplayItem&, size_t index, DisplayItemIndicesByClientMap&);

- DisplayItems::iterator findOutOfOrderCachedItem(DisplayItems::iterator currentIt, const DisplayItem::Id&, DisplayItemIndicesByClientMap&);

- DisplayItems::iterator findOutOfOrderCachedItemForward(DisplayItems::iterator currentIt, const DisplayItem::Id&, DisplayItemIndicesByClientMap&);

+ DisplayItems::iterator findOutOfOrderCachedItem(DisplayItems::iterator& nextItemToIndexIt, const DisplayItem::Id&, DisplayItemIndicesByClientMap&);

+ DisplayItems::iterator findOutOfOrderCachedItemForward(DisplayItems::iterator& nextItemToIndexIt, const DisplayItem::Id&, DisplayItemIndicesByClientMap&);

void copyCachedSubtree(DisplayItems::iterator& currentIt, DisplayItems& updatedList);

#if ENABLE(ASSERT)