fpdfsdk/include/javascript/JS_Object.h - Issue 1287863002: Remove if checks after new.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/javascript/JS_Object.h

Issue 1287863002: Remove if checks after new. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: nits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/javascript/JS_Object.h

diff --git a/fpdfsdk/include/javascript/JS_Object.h b/fpdfsdk/include/javascript/JS_Object.h

index fd63d98cbc1e6f1a0c0d78fb9f48a10211a2a1e4..c0c3ab0c468ce161d686e3a24a11f357e5cca341 100644

--- a/fpdfsdk/include/javascript/JS_Object.h

+++ b/fpdfsdk/include/javascript/JS_Object.h

@@ -109,11 +109,10 @@ struct JS_TIMER_MAPARRAY {

if (JS_TIMER_MAP* pMap = m_Array.GetAt(i))

pMap->pTimer = pTimer;

} else {

- if (JS_TIMER_MAP* pMap = new JS_TIMER_MAP) {

- pMap->nID = nIndex;

- pMap->pTimer = pTimer;

- m_Array.Add(pMap);

- }

+ JS_TIMER_MAP* pMap = new JS_TIMER_MAP;

+ pMap->nID = nIndex;

+ pMap->pTimer = pTimer;

+ m_Array.Add(pMap);

}

« no previous file with comments | « fpdfsdk/include/fxedit/fxet_edit.h ('k') | fpdfsdk/src/fxedit/fxet_list.cpp » ('j') | no next file with comments »