Chromium Code Reviews| Index: fpdfsdk/include/javascript/JS_Object.h |
| diff --git a/fpdfsdk/include/javascript/JS_Object.h b/fpdfsdk/include/javascript/JS_Object.h |
| index fd63d98cbc1e6f1a0c0d78fb9f48a10211a2a1e4..c0c3ab0c468ce161d686e3a24a11f357e5cca341 100644 |
| --- a/fpdfsdk/include/javascript/JS_Object.h |
| +++ b/fpdfsdk/include/javascript/JS_Object.h |
| @@ -109,11 +109,10 @@ struct JS_TIMER_MAPARRAY { |
| if (JS_TIMER_MAP* pMap = m_Array.GetAt(i)) |
| pMap->pTimer = pTimer; |
| } else { |
| - if (JS_TIMER_MAP* pMap = new JS_TIMER_MAP) { |
| - pMap->nID = nIndex; |
| - pMap->pTimer = pTimer; |
| - m_Array.Add(pMap); |
| - } |
| + JS_TIMER_MAP* pMap = new JS_TIMER_MAP; |
| + pMap->nID = nIndex; |
|
Tom Sepez
2015/08/12 22:20:37
nit: Pity the ctor doesn't take these and set them
|
| + pMap->pTimer = pTimer; |
| + m_Array.Add(pMap); |
|
Tom Sepez
2015/08/13 15:39:54
as a follow-up, note that all this JS_TIMER_MAP /
Tom Sepez
2015/08/13 20:48:13
NM. See
https://codereview.chromium.org/128638300
Lei Zhang
2015/08/13 22:23:57
Leaving this file as is.
|
| } |
| } |