Issue 1287853007: Rename is_chromeos in harfbuzz.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1287853007: Rename is_chromeos in harfbuzz. (Closed)

Created:
5 years, 4 months ago by Peter Mayo

Modified:
5 years, 3 months ago

Reviewers:
eae

CC:
chromium-reviews, eae

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename is_chromeos in harfbuzz. is_chromeos does a poor job of distinguishing developer builds of chrome for chromeos for your desktop, and chrome for chromeos on a device (where the runtimes are non local, for example) Split this into is_chromeos_ui and is_chromeos_os. BUG=519943 TEST=ChromiumOS compiles equivalently.

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	third_party/harfbuzz-ng/BUILD.gn	View		3 chunks	+8 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Peter Mayo

upload suggested eae@chromium.org as a reviewer. dependent on https://codereview.chromium.org/1283313004/ - wait for the fireworks there.

5 years, 4 months ago (2015-08-13 01:17:36 UTC) #1

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages