Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: runtime/vm/atomic.h

Issue 1287853005: Compatible atomics: volatile for LoadRelaxed, replace FetchAndAdd with FetchAndDecrement. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Additional comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/atomic_android.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_ATOMIC_H_ 5 #ifndef VM_ATOMIC_H_
6 #define VM_ATOMIC_H_ 6 #define VM_ATOMIC_H_
7 7
8 #include "platform/globals.h" 8 #include "platform/globals.h"
9 9
10 #include "vm/allocation.h" 10 #include "vm/allocation.h"
11 #include "vm/simulator.h" 11 #include "vm/simulator.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 class AtomicOperations : public AllStatic { 15 class AtomicOperations : public AllStatic {
16 public: 16 public:
17 // Atomically fetch the value at p and increment the value at p. 17 // Atomically fetch the value at p and increment the value at p.
18 // Returns the original value at p. 18 // Returns the original value at p.
19 // 19 //
20 // NOTE: Not to be used for any atomic operations involving memory locations 20 // NOTE: Not to be used for any atomic operations involving memory locations
21 // that are accessed by generated code 21 // that are accessed by generated code
22 static uintptr_t FetchAndIncrement(uintptr_t* p); 22 static uintptr_t FetchAndIncrement(uintptr_t* p);
23 23
24 static intptr_t FetchAndAdd(intptr_t* p, intptr_t delta); 24 // Atomically fetch the value at p and decrement the value at p.
25 // Returns the original value at p.
26 //
27 // NOTE: Not to be used for any atomic operations involving memory locations
28 // that are accessed by generated code
29 static uintptr_t FetchAndDecrement(uintptr_t* p);
25 30
31 // Atomically compare *ptr to old_value, and if equal, store new_value.
32 // Returns the original value at ptr.
33 //
34 // NOTE: OK to use with memory locations that are accessed by generated code
26 static uword CompareAndSwapWord(uword* ptr, uword old_value, uword new_value); 35 static uword CompareAndSwapWord(uword* ptr, uword old_value, uword new_value);
27 36
37 // Performs a load of a word from 'ptr', but without any guarantees about
38 // memory order (i.e., no load barriers/fences).
28 static uword LoadRelaxed(uword* ptr) { 39 static uword LoadRelaxed(uword* ptr) {
29 uword result; 40 return *static_cast<volatile uword*>(ptr);
30 memcpy(&result, ptr, sizeof(result));
31 return result;
32 } 41 }
33 }; 42 };
34 43
35 44
36 } // namespace dart 45 } // namespace dart
37 46
38 // We need to use the simulator to ensure that atomic operations are observed 47 // We need to use the simulator to ensure that atomic operations are observed
39 // both in C++ and in generated code if the simulator is active. 48 // both in C++ and in generated code if the simulator is active.
40 #include "vm/atomic_simulator.h" 49 #include "vm/atomic_simulator.h"
41 50
42 #if defined(TARGET_OS_ANDROID) 51 #if defined(TARGET_OS_ANDROID)
43 #include "vm/atomic_android.h" 52 #include "vm/atomic_android.h"
44 #elif defined(TARGET_OS_LINUX) 53 #elif defined(TARGET_OS_LINUX)
45 #include "vm/atomic_linux.h" 54 #include "vm/atomic_linux.h"
46 #elif defined(TARGET_OS_MACOS) 55 #elif defined(TARGET_OS_MACOS)
47 #include "vm/atomic_macos.h" 56 #include "vm/atomic_macos.h"
48 #elif defined(TARGET_OS_WINDOWS) 57 #elif defined(TARGET_OS_WINDOWS)
49 #include "vm/atomic_win.h" 58 #include "vm/atomic_win.h"
50 #else 59 #else
51 #error Unknown target os. 60 #error Unknown target os.
52 #endif 61 #endif
53 62
54 #endif // VM_ATOMIC_H_ 63 #endif // VM_ATOMIC_H_
OLDNEW
« no previous file with comments | « runtime/tests/vm/vm.status ('k') | runtime/vm/atomic_android.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698