core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp - Issue 1287843004: Fix some -Wmaybe-uninitialized errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

Issue 1287843004: Fix some -Wmaybe-uninitialized errors. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

index 488d8393c79ce247a05560d7ea57943b1e8be741..1dd0ae6170a95bc0d14722b8de31dd584fa39513 100644

--- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

+++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_image.cpp

@@ -218,7 +218,7 @@ void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap,

int32_t maskWidth = pMaskBitmap->GetWidth();

int32_t maskHeight = pMaskBitmap->GetHeight();

uint8_t* mask_buf = NULL;

- FX_STRSIZE mask_size;

+ FX_STRSIZE mask_size = 0;

Lei Zhang 2015/08/18 20:10:31 _DCTEncodeBitmap() and _JBIG2EncodeBitmap() are no

CPDF_Dictionary* pMaskDict = new CPDF_Dictionary;

pMaskDict->SetAtName(FX_BSTRC("Type"), FX_BSTRC("XObject"));

pMaskDict->SetAtName(FX_BSTRC("Subtype"), FX_BSTRC("Image"));