Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1287733002: Revert of Gets //mandoline passing gn check (Closed)

Created:
5 years, 4 months ago by sky
Modified:
5 years, 4 months ago
CC:
chromium-reviews, penghuang+watch-mandoline_chromium.org, sadrul, yzshen+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Gets //mandoline passing gn check (patchset #1 id:1 of https://codereview.chromium.org/1278803006/ ) Reason for revert: Broke android http://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/29201 Original issue's description: > Gets //mandoline passing gn check > > BUG=none > TEST=none > R=ben@chromium.org > > Committed: https://crrev.com/c202fc81d0b4931cb928672e5cd226e51e501ea9 > Cr-Commit-Position: refs/heads/master@{#342890} TBR=ben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/52337f682fac60f32908d02e0a106723dc8c4aec Cr-Commit-Position: refs/heads/master@{#342922}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M .gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/app/desktop/main.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/services/updater/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/tab/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M mandoline/ui/aura/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/browser/BUILD.gn View 3 chunks +2 lines, -10 lines 0 comments Download
M mandoline/ui/omnibox/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Gets //mandoline passing gn check
5 years, 4 months ago (2015-08-11 22:42:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287733002/1
5 years, 4 months ago (2015-08-11 22:43:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 22:44:21 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 22:44:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52337f682fac60f32908d02e0a106723dc8c4aec
Cr-Commit-Position: refs/heads/master@{#342922}

Powered by Google App Engine
This is Rietveld 408576698