Restart plugin loading only if the plugin list has actually become stale.

content/browser/plugin_loader_posix.h

Index: content/browser/plugin_loader_posix.h
diff --git a/content/browser/plugin_loader_posix.h b/content/browser/plugin_loader_posix.h
index 60cd5c61221ccc3804af2a4bd84c3a08a4959cf5..3b1ce1d6968b17719b14ffa3c5a763753b1a3c4a 100644
--- a/content/browser/plugin_loader_posix.h
+++ b/content/browser/plugin_loader_posix.h
@@ -5,7 +5,6 @@
 #ifndef CONTENT_BROWSER_PLUGIN_LOADER_POSIX_H_
 #define CONTENT_BROWSER_PLUGIN_LOADER_POSIX_H_
 
-#include <deque>
 #include <vector>
 
 #include "base/basictypes.h"
@@ -52,9 +51,7 @@ class CONTENT_EXPORT PluginLoaderPosix
   PluginLoaderPosix();
 
   // Must be called from the IO thread.
-  void LoadPlugins(
-      scoped_refptr<base::MessageLoopProxy> target_loop,

[Robert Sesek, 2014/01/21 15:17:22]

You're changing the calling semantics in terms of which thread |callback| is run
on. Can you now document on which thread |callback| is run?

[Bernhard Bauer, 2014/01/21 15:48:25]

Done.

-      const PluginService::GetPluginsCallback& callback);
+  void GetPlugins(const PluginService::GetPluginsCallback& callback);
 
   // UtilityProcessHostClient:
   virtual void OnProcessCrashed(int exit_code) OVERRIDE;
@@ -64,15 +61,6 @@ class CONTENT_EXPORT PluginLoaderPosix
   virtual bool Send(IPC::Message* msg) OVERRIDE;
 
  private:
-  struct PendingCallback {
-    PendingCallback(scoped_refptr<base::MessageLoopProxy> target_loop,
-                    const PluginService::GetPluginsCallback& callback);
-    ~PendingCallback();
-
-    scoped_refptr<base::MessageLoopProxy> target_loop;
-    PluginService::GetPluginsCallback callback;
-  };
-
   virtual ~PluginLoaderPosix();
 
   // Called on the FILE thread to get the list of plugin paths to probe.
@@ -81,6 +69,13 @@ class CONTENT_EXPORT PluginLoaderPosix
   // Must be called on the IO thread.
   virtual void LoadPluginsInternal();
 
+  void GetPluginsWrapper(

[Robert Sesek, 2014/01/21 15:17:22]

Please comment.

[Bernhard Bauer, 2014/01/21 15:48:25]

Done.

+      const PluginService::GetPluginsCallback& callback,
+      const std::vector<WebPluginInfo>& plugins);
+
+  void PluginLoadingFinished(
+      const std::vector<WebPluginInfo>& plugins);
+
   // Message handlers.
   void OnPluginLoaded(uint32 index, const WebPluginInfo& plugin);
   void OnPluginLoadFailed(uint32 index, const base::FilePath& plugin_path);
@@ -113,7 +108,7 @@ class CONTENT_EXPORT PluginLoaderPosix
 
   // The callback and message loop on which the callback will be run when the
   // plugin loading process has been completed.
-  std::deque<PendingCallback> callbacks_;
+  std::vector<PluginService::GetPluginsCallback> callbacks_;
 
   // The time at which plugin loading started.
   base::TimeTicks load_start_time_;