Run tests that do not have any compile targets if source files change.

scripts/slave/recipes/chromium_trybot.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from infra.libs.infra_types import freeze
 
 DEPS = [
   'bot_update',
   'chromium',
   'chromium_android',
@@ skipping 435 matching lines @@
 
   return result
 
 
 def all_compile_targets(api, tests):
   """Returns the compile_targets for all the Tests in |tests|."""
   return sorted(set(x
                     for test in tests
                     for x in test.compile_targets(api)))
 
+def is_source_file(api, filepath):
+  """Returns true iff the file is a source file."""
+  _, ext = api.path.splitext(filepath)
+  return ext in ['.c', '.cc', '.cpp', '.h', '.java', '.mm']
+
 
 def _RunStepsInternal(api):
   def get_bot_config(mastername, buildername):
     master_dict = BUILDERS.get(mastername, {})
     return master_dict.get('builders', {}).get(buildername)
 
   mastername = api.properties.get('mastername')
   buildername = api.properties.get('buildername')
   bot_config = get_bot_config(mastername, buildername)
   api.chromium_tests.configure_swarming('chromium', precommit=True)
@@ skipping 83 matching lines @@
     # trying to isolate affected targets may fail.
     tests = []
     tests_including_triggered = []
   else:
     # Note that compile_targets doesn't necessarily include matching_exes,
     # and for correctness we need to add them. Otherwise it's possible we'd
     # only build say foo_unittests but not foo_unittests_run and fail when
     # trying to isolate the tests. Also see above comment.
     compile_targets = sorted(set(compile_targets + matching_exes))
 
-  if not requires_compile:
-    return
+  if requires_compile:
+    tests = tests_in_compile_targets(api, matching_exes, tests)
+    tests_including_triggered = tests_in_compile_targets(
+        api, matching_exes, tests_including_triggered)
 
-  tests = tests_in_compile_targets(api, matching_exes, tests)
-  tests_including_triggered = tests_in_compile_targets(
-      api, matching_exes, tests_including_triggered)
-
-  api.chromium_tests.compile_specific_targets(
-      bot_config['mastername'],
-      bot_config['buildername'],
-      bot_update_step,
-      master_dict,
-      compile_targets,
-      tests_including_triggered,
-      override_bot_type='builder_tester')
+    api.chromium_tests.compile_specific_targets(
+        bot_config['mastername'],
+        bot_config['buildername'],
+        bot_update_step,
+        master_dict,
+        compile_targets,
+        tests_including_triggered,
+        override_bot_type='builder_tester')
+  else:
+    # Even though the patch doesn't compile on this platform, we'd still like
+    # to run tests not depending on compiled targets (that's obviously not
+    # covered by the 'analyze' step) if any source files change.
+    if any([is_source_file(api, f) for f in affected_files]):
+      tests = [t for t in tests if not t.compile_targets(api)]
 
   if not tests:
     return
 
   api.chromium_tests.run_tests_and_deapply_as_needed(mastername, api, tests,
                                                      bot_update_step)
 
 
 def RunSteps(api):
   with api.tryserver.set_failure_hash():
@@ skipping 570 matching lines @@
 
   yield (
     api.test('swarming_paths') +
     api.properties.tryserver(
       mastername='tryserver.chromium.linux',
       buildername='linux_chromium_rel_ng',
       path_config='swarming',
     ) +
     api.platform.name('linux')
   )