|
Delete blink code for scroll-blocks-on
We've decided that controlling scroll blocking behavior is something
that really needs to be tied to event listeners via a JS API, not
a CSS property. The platform needs to mediate the composition here
(eg. for two unrelated libraries both adding touch handlers to the
document), and there's no good way to mediate that composition using
CSS. It's really a property of the event handler and so should be
specified at addEventListener time.
http://crbug.com/489802 tracks the first step of that design
(EventListenerOptions). So it's time to remove the scroll-blocks-on
CSS support from blink. I expect the utlimate compositor integration
for EventListenerOptions mayCancel to be similar, and so for now
I'm leaving the hooks in place in GraphicsLayer.
This change also fixes a regression where iframes could occasionally
not get displayed. I don't understand how the scroll-blocks-on code
(even when not enabled) was triggering that problem, but since it's
going away I'm not going to investigate further.
BUG= 347272, 490358
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200448
Total comments: 2
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+56 lines, -1038 lines) |
Patch |
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-default.html
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-default-expected.txt
|
View
|
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-document.html
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-document-expected.txt
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-explicit.html
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-explicit-expected.txt
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-iframe.html
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-iframe-expected.txt
|
View
|
|
1 chunk |
+0 lines, -122 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-script.html
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-script-expected.txt
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-svg.svg
|
View
|
|
1 chunk |
+0 lines, -18 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/layer-creation/scroll-blocks-on-svg-expected.txt
|
View
|
|
1 chunk |
+0 lines, -17 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/squashing/no-squashing-for-scroll-blocks-on.html
|
View
|
|
1 chunk |
+0 lines, -19 lines |
0 comments
|
Download
|
|
D |
LayoutTests/compositing/squashing/no-squashing-for-scroll-blocks-on-expected.txt
|
View
|
|
1 chunk |
+0 lines, -43 lines |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css/getComputedStyle/computed-style-listing-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
D |
LayoutTests/fast/css/scroll-blocks-on-parsing.html
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
|
D |
LayoutTests/fast/css/scroll-blocks-on-parsing-expected.txt
|
View
|
|
1 chunk |
+0 lines, -57 lines |
0 comments
|
Download
|
|
M |
LayoutTests/inspector/elements/styles-4/styles-new-API-expected.txt
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-default-expected.txt
|
View
|
|
1 chunk |
+0 lines, -20 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-document-expected.txt
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-explicit-expected.txt
|
View
|
|
1 chunk |
+0 lines, -26 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-iframe-expected.txt
|
View
|
|
1 chunk |
+0 lines, -108 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-script-expected.txt
|
View
|
|
1 chunk |
+0 lines, -21 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/layer-creation/scroll-blocks-on-svg-expected.txt
|
View
|
|
1 chunk |
+0 lines, -14 lines |
0 comments
|
Download
|
|
D |
LayoutTests/platform/android/compositing/squashing/no-squashing-for-scroll-blocks-on-expected.txt
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
|
M |
LayoutTests/svg/css/getComputedStyle-listing-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
LayoutTests/webexposed/css-properties-as-js-properties-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/CSSComputedStyleDeclaration.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/CSSPrimitiveValueMappings.h
|
View
|
|
2 chunks |
+0 lines, -20 lines |
0 comments
|
Download
|
|
M |
Source/core/css/CSSProperties.in
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/CSSValueKeywords.in
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
Source/core/css/ComputedStyleCSSValueMapping.cpp
|
View
|
|
2 chunks |
+0 lines, -19 lines |
0 comments
|
Download
|
|
M |
Source/core/css/html.css
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/css/parser/CSSPropertyParser.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/parser/CSSPropertyParser.cpp
|
View
|
1
2
|
2 chunks |
+0 lines, -32 lines |
0 comments
|
Download
|
|
M |
Source/core/css/resolver/StyleResolver.cpp
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/css/svg.css
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/dom/Document.cpp
|
View
|
1
2
|
3 chunks |
+1 line, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/frame/UseCounter.cpp
|
View
|
1
2
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/LayoutBox.cpp
|
View
|
1
2
|
1 chunk |
+0 lines, -9 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/compositing/CompositedDeprecatedPaintLayerMapping.cpp
|
View
|
|
3 chunks |
+0 lines, -16 lines |
0 comments
|
Download
|
|
M |
Source/core/layout/compositing/CompositingReasonFinder.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/core/layout/compositing/CompositingReasonFinder.cpp
|
View
|
|
3 chunks |
+0 lines, -53 lines |
0 comments
|
Download
|
|
M |
Source/core/style/ComputedStyle.h
|
View
|
|
4 chunks |
+0 lines, -5 lines |
0 comments
|
Download
|
|
M |
Source/core/style/StyleRareNonInheritedData.h
|
View
|
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
|
M |
Source/core/style/StyleRareNonInheritedData.cpp
|
View
|
|
3 chunks |
+1 line, -4 lines |
0 comments
|
Download
|
|
M |
Source/core/testing/Internals.idl
|
View
|
1
2
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/devtools/front_end/timeline/LayerDetailsView.js
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/platform/RuntimeEnabledFeatures.in
|
View
|
1
2
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
Source/platform/graphics/CompositingReasons.h
|
View
|
1
|
3 chunks |
+47 lines, -50 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/CompositingReasons.cpp
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/GraphicsLayer.cpp
|
View
|
|
2 chunks |
+3 lines, -11 lines |
0 comments
|
Download
|
|
M |
Source/platform/graphics/GraphicsLayerClient.h
|
View
|
|
1 chunk |
+2 lines, -3 lines |
0 comments
|
Download
|
Total messages: 15 (5 generated)
|