update analyzer version - related to #23947

update analyzer version - related to #23947
and https://codereview.chromium.org/1281793004/

R=paulberry@google.com

Committed: https://github.com/dart-lang/sdk/commit/43f2f0a00de48ba3f032f9f6812efbf320ee1d4f

[danrubel, 2015-08-11 18:41:53]

danrubel@google.com changed reviewers:
+ paulberry@google.com

[danrubel, 2015-08-11 18:41:53]

I fixed a bug in analyzer and need that new version in analysis_server for
correct code completion. Is this the correct way to go about pulling in a new
version? are there additional changes needed?

[Brian Wilkerson, 2015-08-11 18:51:54]

brianwilkerson@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2015-08-11 18:51:54]

You also need to update the DEPS file to pull it into the SDK.

[danrubel, 2015-08-11 19:06:37]

On 2015/08/11 18:51:54, Brian Wilkerson wrote:
> You also need to update the DEPS file to pull it into the SDK.

Sorry... which DEPS ?

[Brian Wilkerson, 2015-08-11 19:08:57]

> Sorry... which DEPS ?

Sorry, that's only necessary for analyzer_cli. Ignore my comment.

[Paul Berry, 2015-08-12 16:40:04]

The change lgtm.  However, after discussing this with Brian, we think that the
following steps need to be performed (in order):

1. Land a CL that changes the analyzer version.
2. Publish the new version of analyzer.
3. Land a CL that changes analysis_server to depend on the new version of
analyzer.

Your CL does steps 1 and 3, which means it's not safe (because we can't do 2 as
an intermediate step).

So I would recommend splitting it into 2 separate CL's.

[danrubel, 2015-08-15 18:47:44]

On 2015/08/12 16:40:04, Paul Berry wrote:
> The change lgtm.  However, after discussing this with Brian, we think that the
> following steps need to be performed (in order):
> 
> 1. Land a CL that changes the analyzer version.
> 2. Publish the new version of analyzer.
> 3. Land a CL that changes analysis_server to depend on the new version of
> analyzer.
> 
> Your CL does steps 1 and 3, which means it's not safe (because we can't do 2
as
> an intermediate step).
> 
> So I would recommend splitting it into 2 separate CL's.

Good point. I'll land these as separate CLs with a publish in between.

[danrubel, 2015-08-15 18:48:26]

Committed patchset #2 (id:20001) manually as
43f2f0a00de48ba3f032f9f6812efbf320ee1d4f (presubmit successful).

[danrubel, 2015-08-15 18:56:15]

On 2015/08/15 18:48:26, danrubel wrote:
> Committed patchset #2 (id:20001) manually as
> 43f2f0a00de48ba3f032f9f6812efbf320ee1d4f (presubmit successful).

Subsequent CL https://codereview.chromium.org/1288653003