Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Issue 1287543005: Make `python build/vs_toolchain.py update` mostly work on non-Windows. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
scottmg
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make `python build/vs_toolchain.py update` mostly work on non-Windows. 1. GetFileList() returns a list of path\names on Windows but of path/names on non-Windows. To not perturb existing hashes, I guess the hashing code should do path.replace('/', '\\') before hashing. 2. GetFileList() returns a sorted list of filenames, and \ compares pretty different than / (the former is less than all numbers while the latter is greater, for example). So replace / with \\ for sorting too. With this change, OS X produces the same file hash as Windows. The script still early-exits on non-Windows, so no visible change yet. BUG=495204 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296271

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M win_toolchain/get_toolchain_if_necessary.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Nico
Have more mail!
5 years, 4 months ago (2015-08-11 20:08:36 UTC) #2
scottmg
lgtm
5 years, 4 months ago (2015-08-11 20:09:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287543005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287543005/1
5 years, 4 months ago (2015-08-11 20:14:30 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 20:16:21 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296271

Powered by Google App Engine
This is Rietveld 408576698