Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1287543004: [Atomics] Fix compile failure in clang/win build in runtime-atomics.cc (Closed)

Created:
5 years, 4 months ago by binji
Modified:
5 years, 4 months ago
Reviewers:
Nico, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Atomics] Fix compile failure in clang/win build in runtime-atomics.cc BUG=v8:4366 LOG=n Committed: https://crrev.com/60268ceecd72322092edf91f888a7e58050dba70 Cr-Commit-Position: refs/heads/master@{#30138}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -37 lines) Patch
M src/runtime/runtime-atomics.cc View 1 2 chunks +42 lines, -37 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
lgtm
5 years, 4 months ago (2015-08-12 04:22:58 UTC) #2
Nico
lgtm, thanks!
5 years, 4 months ago (2015-08-12 16:37:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287543004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287543004/20001
5 years, 4 months ago (2015-08-12 16:42:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 16:44:17 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 16:44:39 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/60268ceecd72322092edf91f888a7e58050dba70
Cr-Commit-Position: refs/heads/master@{#30138}

Powered by Google App Engine
This is Rietveld 408576698