Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 128753002: Remove SetHostSize/Bounds from RootWindow in favor of just calling SetBounds() on host() (Closed)

Created:
6 years, 11 months ago by Ben Goodger (Google)
Modified:
6 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, tfarina, ben+aura_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, ben+corewm_chromium.org, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Remove SetHostSize/Bounds from RootWindow in favor of just calling SetBounds() on host() R=sky@chromium.org http://crbug.com/308846 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244005 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244244

Patch Set 1 #

Patch Set 2 : / #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : weirdness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -50 lines) Patch
M ash/display/display_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/display/virtual_keyboard_window_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 chunks +8 lines, -27 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ben Goodger (Google)
6 years, 11 months ago (2014-01-08 17:36:50 UTC) #1
sky
LGTM
6 years, 11 months ago (2014-01-08 21:16:42 UTC) #2
Ben Goodger (Google)
Committed patchset #5 manually as r244005 (presubmit successful).
6 years, 11 months ago (2014-01-09 22:46:05 UTC) #3
Ben Goodger (Google)
6 years, 11 months ago (2014-01-10 21:27:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #7 manually as r244244 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698