Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1287513003: Handle Performance object creation on loader-less Documents. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handle Performance object creation on loader-less Documents. Speculatively fix reported null crasher in Performance ctor, checking if Document has a DocumentLoader before accessing. Should this object be created while its frame is being detached (see bug stack trace), this can potentially happen. R=haraken,ksakamoto BUG=518775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200307

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M Source/core/timing/Performance.cpp View 1 chunk +17 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look. I don't think this is overly defensive, but I haven't been ...
5 years, 4 months ago (2015-08-11 06:12:07 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-11 06:25:02 UTC) #3
Kunihiko Sakamoto
lgtm
5 years, 4 months ago (2015-08-11 06:27:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287513003/1
5 years, 4 months ago (2015-08-11 08:15:16 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 08:17:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200307

Powered by Google App Engine
This is Rietveld 408576698