runtime/vm/visitor.h - Issue 1287463003: Refactor skipped code functions interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/visitor.h

Issue 1287463003: Refactor skipped code functions interface. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/visitor.h

diff --git a/runtime/vm/visitor.h b/runtime/vm/visitor.h

index 70fe619e215df01ff34ad7f4c16c3f81b3fd4e2a..6e3373be3fd686fa12ad30ff0a91b04061d78c28 100644

--- a/runtime/vm/visitor.h

+++ b/runtime/vm/visitor.h

@@ -26,8 +26,8 @@ class ObjectPointerVisitor {

virtual void VisitPointers(RawObject** first, RawObject** last) = 0;

virtual bool visit_function_code() const { return true; }

- virtual MallocGrowableArray<RawFunction*>* skipped_code_functions() {

- return NULL;

+ virtual void add_skipped_code_function(RawFunction* funct) {

+ UNREACHABLE();

}

// len argument is the number of pointers to visit starting from 'p'.

void VisitPointers(RawObject** p, intptr_t len) {

« runtime/vm/gc_marker.cc ('K') | « runtime/vm/raw_object.cc ('k') | no next file » | no next file with comments »