ui/views/accessibility/native_view_accessibility.cc - Issue 1287463002: Call RemoveObserver from OnWidgetDestroying

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/accessibility/native_view_accessibility.cc

Issue 1287463002: Call RemoveObserver from OnWidgetDestroying (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added test Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/accessibility/native_view_accessibility.cc

diff --git a/ui/views/accessibility/native_view_accessibility.cc b/ui/views/accessibility/native_view_accessibility.cc

index a11f773d62a67e816bda3fb3a240bd1bed693905..db8367fcefb1554900df50451b58c166d58bd943 100644

--- a/ui/views/accessibility/native_view_accessibility.cc

+++ b/ui/views/accessibility/native_view_accessibility.cc

@@ -203,8 +203,10 @@ bool NativeViewAccessibility::SetStringValue(const base::string16& new_value) {

}

void NativeViewAccessibility::OnWidgetDestroying(Widget* widget) {

- if (parent_widget_ == widget)

+ if (parent_widget_ == widget) {

+ parent_widget_->RemoveObserver(this);

parent_widget_ = nullptr;

+ }

}

void NativeViewAccessibility::SetParentWidget(Widget* parent_widget) {

« no previous file with comments | « no previous file | ui/views/accessibility/native_view_accessibility_unittest.cc » ('j') | no next file with comments »