Issue 1287453002: change param name to match docs

Issue 1287453002: change param name to match docs (Closed)

Created:
5 years, 4 months ago by sethladd

Modified:
5 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

change param name to match docs BUG= R=lrn@google.com Committed: https://github.com/dart-lang/sdk/commit/b30a7a1750cd13c92781480f8708974b84385cad

Patch Set 2 : more renames #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	sdk/lib/collection/iterable.dart	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	sdk/lib/core/iterable.dart	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

LGTM. Could you also fix "skip" (and even take+skip in sdk/lib/collaction/iterable.dart too, which contains the ...

5 years, 4 months ago (2015-08-11 06:07:00 UTC) #3

sethladd

https://codereview.chromium.org/1287453002/diff/1/sdk/lib/core/iterable.dart File sdk/lib/core/iterable.dart (right): https://codereview.chromium.org/1287453002/diff/1/sdk/lib/core/iterable.dart#newcode425 sdk/lib/core/iterable.dart:425: Iterable<E> skip(int n) { On 2015/08/11 06:07:00, Lasse Reichstein ...

5 years, 4 months ago (2015-08-11 14:48:13 UTC) #5

sethladd

5 years, 4 months ago (2015-08-11 17:55:20 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b30a7a1750cd13c92781480f8708974b84385cad (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages